Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MLS to native forms #373

Merged
merged 26 commits into from
Mar 13, 2020
Merged

Add MLS to native forms #373

merged 26 commits into from
Mar 13, 2020

Conversation

vincent-karuri
Copy link
Contributor

Closes #367

@vincent-karuri
Add util that replaces mls placeholders with a literal string
49dc519
@vincent-karuri
Add mls test property and json files
8ecce94
@vincent-karuri
Move test files to test resources dir and add resource bundle propert…
354972b 
…y fetching logic
@vincent-karuri
Modify regex to include enclosing quotation marks around interpolated…
c229303 
… string
@vincent-karuri
Add test for en_US translation
4ce15ca
@vincent-karuri
Code clean-up
ce45822
@vincent-karuri
Get the translations' property file name from the json form
7e4736a
@vincent-karuri
Enable translating native forms at launch
7028f0f
@vincent-karuri
Rename method
3a07d8e
@vincent-karuri
Add yaml file translation support
abbfba7
@vincent-karuri
Rename form translation test files and modify interpolation regex to …
bd98cf4 
…consider yaml syntax
@vincent-karuri
Test yaml translation
2707dc9
@vincent-karuri
Modify how yaml files are read to account for new line characters
db8c3ec
@vincent-karuri
Minor refactore
3430e70
@vincent-karuri
Return untranslated String if the translations property file is not s…
f38d260 
…pecified
@vincent-karuri vincent-karuri self-assigned this Mar 2, 2020
@vincent-karuri vincent-karuri changed the title Add mls support to native forms Add MLS to native forms Mar 9, 2020
ndegwamartin
ndegwamartin previously approved these changes Mar 13, 2020
View reviewed changes
@vincent-karuri
Bump lib version
198d9ce
@vincent-karuri
Merge branch '367-add-mls-support-to-native-forms' of github.com:Open…
4c152c3 
…SRP/opensrp-client-native-form into 367-add-mls-support-to-native-forms
@vincent-karuri vincent-karuri merged commit 5011d67 into master Mar 13, 2020
@vincent-karuri vincent-karuri deleted the 367-add-mls-support-to-native-forms branch March 13, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndegwamartin ndegwamartin ndegwamartin approved these changes

@githengi githengi Awaiting requested review from githengi

Assignees

@vincent-karuri vincent-karuri

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MLS support to native forms
3 participants
@vincent-karuri @ndegwamartin @dubdabasoduba